Issues

ZF-12006: FlashMessenger does not update messageAdded variable when message is added

Issue Type: Bug Created: 2012-01-17T15:03:57.000+0000 Last Updated: 2012-05-22T16:52:32.000+0000 Status: Resolved Fix version(s): - 1.12.0 (27/Aug/12)

Reporter: Dominic Luechinger (dol) Assignee: Dominic Luechinger (dol) Tags: - Zend_Controller

  • zf-crteam-review

Related issues: Attachments: - FlashMessenger.php.patch

Description

The Zend_Controller_Action_Helper_FlashMessenger has a static variable '$_messageAdded', which is never changed. In ZF2, this issue is resolved by $_messageAdded to true after adding a message.

Comments

Posted by Dominic Luechinger (dol) on 2012-01-17T15:04:30.000+0000

Patch to this problem

Posted by Adam Lundrigan (adamlundrigan) on 2012-02-26T04:36:40.000+0000

Does this solve any particular problem with the ZFv1 flash messenger? The code has changed considerably v1->v2, so is backporting this change appropriate?

Posted by Adam Lundrigan (adamlundrigan) on 2012-05-22T16:52:32.000+0000

After reviewing the suggestion more closely, this is indeed a bug, but it's side-effect is trivial (setExpirationHops is called on each addMessage call instead of just the first)

Fixed in trunk (1.12.0): r24813

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts