Issues

ZF-12500: [CRITICAL BUG + FIX] Zend_Gdata 1.12.1 feed URL generation

Issue Type: Bug Created: 2013-01-05T01:33:08.000+0000 Last Updated: 2013-01-08T08:07:37.000+0000 Status: Resolved Fix version(s): - 1.12.2 (25/Feb/13)

Reporter: Aitte Mitchell (aitte) Assignee: Frank Brückner (frosch) Tags: - Zend_Gdata

Related issues: Attachments: - ZF-12500.patch

Description

Name of API affected: VideoQuery.php: Zend_Gdata_YouTube_VideoQuery()->setFeedType()

Issue summary: The "responses" and "comments" types construct invalid URLs by concatenating as follows: * responses: Zend_Gdata_YouTube::VIDEO_URI . '/' . $videoId . 'responses' * comments: Zend_Gdata_YouTube::VIDEO_URI . '/' . $videoId . 'comments' This generates illegal URLs such as "https://gdata.youtube.com/feeds/api/videos/SZj6rAYkYOgcomments" The "related" type constructs a valid URL in contrast: * related: Zend_Gdata_YouTube::VIDEO_URI . '/' . $videoId . '/related';

Solution: To fix this bug for the responses and comments types, simply change their concatenation lines to: * responses: Zend_Gdata_YouTube::VIDEO_URI . '/' . $videoId . '/responses' * comments: Zend_Gdata_YouTube::VIDEO_URI . '/' . $videoId . '/comments'

Comments

Posted by Aitte Mitchell (aitte) on 2013-01-05T01:40:09.000+0000

Seems this issue tracker is dead. I've reported it here instead: https://github.com/zendframework/zf2/issues/3351

Posted by Frank Brückner (frosch) on 2013-01-05T14:40:11.000+0000

@Aitte No, this tracker is not dead! This is the tracker for version 1 and the tracker on Github is for version 2.

Posted by Frank Brückner (frosch) on 2013-01-05T15:39:23.000+0000

Patch with fix and unit tests added.

Posted by Aitte Mitchell (aitte) on 2013-01-05T17:08:41.000+0000

@Frank Excellent work including unit tests in the patch! Looks good to me.

Posted by Frank Brückner (frosch) on 2013-01-08T08:07:37.000+0000

Fixed on trunk (25184) and release-1.12 (25185)

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts