ZF-2023: Zend_Gdata_Calendar sample code doesn't list setReminder or addExtendedProperty when listing valid commands

Issue Type: Bug Created: 2007-10-01T17:06:04.000+0000 Last Updated: 2008-02-26T12:56:07.000+0000 Status: Resolved Fix version(s): - 1.0.4 (26/Feb/08)

Reporter: Trevor Johns (tjohns) Assignee: Ryan Boyd (rboyd) Tags: - Zend_Gdata

Related issues: Attachments:


When running demos/Zend/Gdata/Calendar.php without any arguments, a list of valid commands is output to stdout. This list is missing the following commands:

  • setReminder
  • addExtendedProperty

These commands are already recognized properly and have interactive help, so they just need to be added to the help text which is output when a command isn't issued by the user.


Posted by Ryan Boyd (rboyd) on 2007-12-06T17:07:16.000+0000

Added additional commands to output and verified that the commands outputted are equal to those in the case statements.

Posted by Ryan Boyd (rboyd) on 2007-12-06T17:07:38.000+0000

Trevor - can you do the code review on this one pleae.

Posted by Trevor Johns (tjohns) on 2007-12-07T13:42:16.000+0000

Code review for r7056

The fix looks good conceptually, though there's a syntax error. The new strings end with a semi-colon (;) rather than the concatenation operator (.). Since fixing this is trivial, I've gone ahead and corrected this in r7059.

<pre class="highlight">
Index: demos/Zend/Gdata/Calendar.php
--- demos/Zend/Gdata/Calendar.php   (revision 7058)
+++ demos/Zend/Gdata/Calendar.php   (revision 7059)
@@ -783,8 +783,8 @@
       "createEvent\n" .
       "createQuickAddEvent\n" .
       "createWebContentEvent\n" .
-       "createRecurringEvent\n";
-       "setReminder\n";
+       "createRecurringEvent\n" .
+       "setReminder\n" .
} else {
  // running through web server - demonstrate AuthSub

With that applied, it looks good to me.

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.