ZF-2951: Inconsistent names

Issue Type: Coding Standards Violation Created: 2008-03-23T13:56:31.000+0000 Last Updated: 2008-11-24T13:14:50.000+0000 Status: Resolved Fix version(s): - 1.8.0 (30/Apr/09)

Reporter: Joó Ádám (ceriak) Assignee: Matthew Weier O'Phinney (matthew) Tags: - Zend_Controller

  • Zend_View

Related issues: Attachments:


Several action helpers have a subpackage name of Zend_Controller_Action instead of Action_Helper:

  • Zend_Controller_Action_Helper_Abstract
  • Zend_Controller_Action_Helper_FlashMessenger
  • Zend_Controller_Action_Helper_Redirector
  • Zend_Controller_Action_Helper_Url
  • Zend_Controller_Action_Helper_ViewRenderer

Also Zend_Controller_Action_HelperBroker which should be marked with the subpackege name of Action, and Zend_Layout_Controller_Action_Helper_Layout which does not reflect the directory structure containing Layout as the second part of the name.

There are view helpers marked as Helpers instead of Helper too:

  • Zend_View_Helper_Action
  • Zend_View_Helper_Doctype
  • Zend_View_Helper_Headlink
  • Zend_View_Helper_HeadMeta
  • Zend_View_Helper_HeadScript
  • Zend_View_Helper_HeadStyle
  • Zend_View_Helper_HeadTitle
  • Zend_View_Helper_InlineScript
  • Zend_View_Helper_PartialLoop
  • Zend_View_Helper_Placeholder
  • Zend_View_Helper_Placeholder_Container
  • Zend_View_Helper_Placeholder_Container_Abstract
  • Zend_View_Helper_Placeholder_Container_Abstract_Standalone
  • Zend_View_Helper_Placeholder_Registry


Posted by Thomas Weidner (thomas) on 2008-03-23T16:45:15.000+0000

The complete API doc is actually being reworked. Also some of the things mentioned by you are already fixed.

Posted by Wil Sinclair (wil) on 2008-03-25T20:23:03.000+0000

Please categorize/fix as needed.

Posted by Ralph Schindler (ralph) on 2008-03-28T12:33:19.000+0000

I am working on this today, Thomas, what has been done & fixed already?

Posted by Thomas Weidner (thomas) on 2008-03-28T12:54:05.000+0000

I'm not sure which version the reporter uses but the "helpers" / "helper" should already been fixed. Actually I am reworking the complete API doc for ZF and I am writing the coding standard for it. This takes much time and is done since 2 weeks and should be finished in about 6 weeks.

As the subpackage tag is only a grouping and not a namespace, I don't see that naming like Zend_Contoller_Action is a failure.

This would mean that php uses "package.subpackage" syntax like java, which is not true. If the intention is to rework this for the complete framework it would be better to wait until I have finished the API doc standard and the dev-team gives it's ok to it.

Actually the complete API doc is not standardized and changing this only for Zend_Controller is useless if not done for all and not consistent to the standard. This is the reason why I've not worked on this, because it's beeing worked on, but on another side. ;-)

Posted by Matthew Weier O'Phinney (matthew) on 2008-05-09T12:16:23.000+0000

Scheduling for next minor release.

Posted by Matthew Weier O'Phinney (matthew) on 2008-11-24T13:14:50.000+0000

I have reviewed all packages listed, and each have the correct subpackage listed at this time.

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.