ZF-3681: Centralize definition of URI delimiter in Zend_Controller_Router_Route_*

Issue Type: Patch Created: 2008-07-18T08:17:48.000+0000 Last Updated: 2011-07-21T18:36:05.000+0000 Status: Resolved Fix version(s): - 1.11.8 (07/Jul/11)

Reporter: Lee Saferite (lsaferite) Assignee: Matthew Weier O'Phinney (matthew) Tags: - Zend_Controller

Related issues: Attachments: - 18-Jul-08.Zend_Controller_Router_Route.patch


Zend_Controller_Router_Route_Module::assemble() in SVN uses '/' when making urls instead of self::URI_DELIMITER. This patch fixes that.


Posted by Lee Saferite (lsaferite) on 2008-07-18T08:19:36.000+0000

Forgot to attach patch

Posted by Lee Saferite (lsaferite) on 2008-07-18T08:29:29.000+0000

This might be a better patch, although I am not sure if putting a const in an interface is considered bad form.

Posted by Kim Blomqvist (kblomqvist) on 2011-04-22T20:42:27.000+0000

URI_DELIMITER constant is introduced only in Zend_Controller_Router_Route_Module and thus it cannot be used in other route classes as suggested in the patch attached in July 2008. In addition line numbers do not apply anymore making this patch pretty much decayed. I think that the URI_DELIMITER should be declared in Zend_Controller_Router_Route_Abstract so that it would also be available in other route classes. However, if I remember correct routing will be largely refactored in ZF2 so this issue could be resolved as won't fix.

Posted by Adam Lundrigan (adamlundrigan) on 2011-07-03T13:43:08.000+0000

Fixed in trunk r24179-r24181 Merged to release-1.11 in r24182

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.