Issues

ZF-4619: isLocale needs changes related to BC problems

Issue Type: Improvement Created: 2008-10-16T14:11:07.000+0000 Last Updated: 2008-11-13T14:09:58.000+0000 Status: Resolved Fix version(s): - 1.7.0 (17/Nov/08)

Reporter: Thomas Weidner (thomas) Assignee: Thomas Weidner (thomas) Tags: - Zend_Locale

Related issues: Attachments:

Description

According to discussion of SL-13 isLocale needs to be slightly adpoted:

Method: isLocale()

Solution: STATIC PROPERTY SET TO TRUE BUT THROWING A NOTICE WHEN TRUE... TRUE = OLD BEHAVIOUR, FALSE = NEW BEHAVIOUR

Information: There are several things to make sure. isXXX functions should generally only return boolean regarding to OOP and Coding Standard. Returning a object was a thing which I used to add for internal reasons. This is no longer needed as rerouting has been added so it is automatically be done by all I18N classes. Also there is another solution: We could add a static boolean option/property 'CREATE_LOCALE_ON_VALIDATION'. A simple note to set this property on true for old behaviour should be ok, shouldn't it ? Because returning an object on a boolean function is really a bad bad behaviour. And we should get rid of this false behaviour as soon as we can.

Comments

Posted by Thomas Weidner (thomas) on 2008-10-17T15:04:34.000+0000

Implemented with r12003

Posted by Wil Sinclair (wil) on 2008-11-13T14:09:58.000+0000

Changing issues in preparation for the 1.7.0 release.

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts