ZF-5145: Zend_Validate_File_Count default messages are not using correct english for error messages

Issue Type: Improvement Created: 2008-12-03T01:46:44.000+0000 Last Updated: 2009-10-24T10:48:17.000+0000 Status: Resolved Fix version(s): - 1.10.0 (27/Jan/10)

Reporter: Loke Dupont (colde) Assignee: Thomas Weidner (thomas) Tags: - Zend_Validate_File

Related issues: - ZF-7248



The message temples and error constants for errors given in Zend_Validate_File_Count are as follows: protected $_messageTemplates = array( self::TOO_MUCH => "Too much files, maximum '%max%' are allowed but '%count%' are given", self::TOO_LESS => "Too less files, minimum '%min%' are expected but '%count%' are given" ); const TOO_MUCH = 'fileCountTooMuch'; const TOO_LESS = 'fileCountTooLess';

I would propose they be changed to protected $_messageTemplates = array( self::TOO_MANY => "Too many files, maximum '%max%' are allowed but '%count%' are given", self::TOO_FEW => "Too few files, minimum '%min%' are expected but '%count%' are given" ); const TOO_MANY = 'fileCountTooHigh'; const TOO_FEW = 'fileCountTooLow';

The constants could possibly be named different, like fileTooManyFiles and fileTooFewFiles or something like that.


Posted by Thomas Weidner (thomas) on 2008-12-03T01:53:49.000+0000

This is a BC break and can not be done without breaking all existing applications.

Constant changes are not allowed.

But you can already change any given default message with your own message and even translation.

Posted by Dolf Schimmel (Freeaqingme) (freak) on 2009-06-15T11:29:35.000+0000

Seems like a nice issue for 2.0?

Edit: I don't seem to be able to set this issue to 'postponed'?

Posted by Thomas Weidner (thomas) on 2009-10-24T10:48:17.000+0000

Fixed with r18683

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.