Issues

ZF-5648: Add source parameter to Zend_Service_Twitter

Issue Type: Improvement Created: 2009-01-28T12:02:01.000+0000 Last Updated: 2009-09-13T11:29:27.000+0000 Status: Closed Fix version(s): Reporter: Marc Fonteijn (marcfonteijn) Assignee: Jon Whitcraft (sidhighwind) Tags: - Zend_Service_Twitter

Related issues: Attachments: - Service.diff

Description

There is no option to specify a 'source' parameter in the Zend_Service_Twitter. This source parameter is used to specify a custom twitter client.

http://apiwiki.twitter.com/FAQ/…

Adding this option should be trivial. Adding a setSource() that adds the 'source' parameter to the data array should do the trick

Comments

Posted by Ivo Jansch (ijansch) on 2009-04-06T15:06:52.000+0000

I have a patch that adds support for the source parameter to the update() method as optional third parameter.

Wil: how do I go about adding this patch, can I just commit it to trunk?

Posted by Ivo Jansch (ijansch) on 2009-04-06T15:25:33.000+0000

Ok, ignore that last comment. Should've known there are contributor guidelines :)

Here's the diff file that patches this bug. Please review and commit.

Posted by Jon Whitcraft (sidhighwind) on 2009-04-07T18:01:46.000+0000

Patch looks good to me. I'll apply it before 1.8 comes out as I have to write a unit test for it and I'm not sure how to do it when I don't have an application id to test with it.

Posted by Ivo Jansch (ijansch) on 2009-05-01T03:06:23.000+0000

I reckon this didn't make it into 1.8 :)

I think for a testcase, it's not necessary to have an actual source id. If you use a mock object, all the testcase needs to verify is whether the source parameter ends up in the api call. (no need to actually test twitter itself).

Posted by Jon Whitcraft (sidhighwind) on 2009-05-01T03:28:54.000+0000

Correct it did not make it into 1.8. I will try and get it into 1.8.1.

Posted by Jon Whitcraft (sidhighwind) on 2009-05-20T09:03:02.000+0000

According to the twitter API (http://apiwiki.twitter.com/Twitter-REST-API-Method…) the source parameter is no longer on the update status method.

Let me do some more digging to see what I can find.

Posted by Jon Whitcraft (sidhighwind) on 2009-09-13T11:29:26.000+0000

This is no longer supported unless you you OAuth:

http://apiwiki.twitter.com/FAQ/…

Closing as Won't Fix

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts