ZF-5742: Zend_Wildfire_Plugin_FirePhp_TableMessage improvement

Issue Type: Improvement Created: 2009-02-11T03:14:13.000+0000 Last Updated: 2009-02-12T00:49:56.000+0000 Status: Resolved Fix version(s): - 1.8.0 (30/Apr/09)

Reporter: roy simkes (radalin) Assignee: Christoph Dorn (cadorn) Tags: - Zend_Wildfire

Related issues: Attachments: - class.profiler.php


Zend_Wildfire_Plugin_FirePhp_TableMessage class has no set/get methods for it's property "rows"

It would be cool to have these methods as we may want to alter the rows previously entered.

This was an issue I had encountered while working on the Zend_Db_Profiler_Firebug. I wanted to alter the table it shows (wanted to add a results column to show the results returning from sql queries), so I extended the Zend_Db_Profiler_Firebug. I did not changed any of the working part (did not alter the queryEnd() part). Once I have fetched my results to an array (as I have called the queryEnd() previously this fetchings does not affect the execution time of the query), I wanted to add these results to the table created by the firebug profiler. But as "_rows" was protected I was unable to get and alter it's data.


Posted by roy simkes (radalin) on 2009-02-11T03:15:32.000+0000

Here is a patch I have written for the current issue. I don't know if that helps or not.

Posted by Christoph Dorn (cadorn) on 2009-02-11T18:23:03.000+0000

Thanks for the patch. I'll apply it ASAP.

Would you be open to sharing your extended Zend_Db_Profiler_Firebug class? I may be able to incorporate it into a new component I am working on for ZF.

Posted by Christoph Dorn (cadorn) on 2009-02-11T20:53:15.000+0000

Applied patch with some modifications and added unit test.

Posted by roy simkes (radalin) on 2009-02-12T00:49:50.000+0000

Of course. Here is the class I extended. It's not much as I did not need a lot of things. Just edited the current row and added a new column to the table.

Have you found an issue?

See the Overview section for more details.


© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.