ZF-6708: Zend_Filter_Input skips ALLOW_EMPTY metacommand processing if any validator is applied to the field

Issue Type: Bug Created: 2009-05-18T05:48:41.000+0000 Last Updated: 2009-10-25T10:31:56.000+0000 Status: Resolved Fix version(s): - 1.8.2 (27/May/09)

Reporter: Alexander Veremyev (alexander) Assignee: Alexander Veremyev (alexander) Tags: - Zend_Filter_Input

Related issues: Attachments:


Zend_Filter_Input skips ALLOW_EMPTY metacommand processing if any validator is applied to the field:

<pre class="highlight">
 * @param array $validatorRule
 * @return void
protected function _validateRule(array $validatorRule)
     * Evaluate the inputs against the validator chain.
    if (count((array) $validatorRule[self::FIELDS]) > 1) {
        if (!$validatorRule[self::VALIDATOR_CHAIN]->isValid($data)) {
            $this->_invalidMessages[$validatorRule[self::RULE]] = $validatorRule[self::VALIDATOR_CHAIN]->getMessages();
            $this->_invalidErrors[$validatorRule[self::RULE]] = $validatorRule[self::VALIDATOR_CHAIN]->getErrors();

<pre class="highlight">
foreach ($field as $value) {
    if (empty($value)) {
        if ($validatorRule[self::ALLOW_EMPTY] == true) {
        if ($validatorRule[self::VALIDATOR_CHAIN_COUNT] == 0) {
            $notEmptyValidator = $this->_getValidator('NotEmpty');
            $notEmptyValidator->setMessage($this->_getNotEmptyMessage($validatorRule[self::RULE], $fieldKey));


Posted by Alexander Veremyev (alexander) on 2009-05-18T06:09:29.000+0000

That was probably done to avoid 'empty value' messages duplication since these messages may come from Validators as well as from Zend_Filter_Input::ALLOW_EMPTY metacommand.

There are two options: * Zend_Filter_Input should interact with Validators in terms of messages semantics and skip their 'empty string' messages. * Throw all messages. So user will be responsibile to turn on Zend_Filter_Input::ALLOW_EMPTY (which is off by default) for specified field.

Posted by Alexander Veremyev (alexander) on 2009-05-18T07:59:38.000+0000

Right behavior is to skip any validation and throw NOT_EMPTY_MESSAGE if empty value is not allowed, but present.

Posted by Alexander Veremyev (alexander) on 2009-05-22T08:03:23.000+0000


Posted by Kevin McArthur (kevin) on 2009-09-16T14:34:07.000+0000

I think this may have introduced a backwards compatibility break. Scenario:

<pre class="highlight"> 
$validation = array(
  'offset' => array (
     'presence' => 'required'

$params = new Zend_Filter_Input(null, $validation, $this->_getAllParams());

Prior to this change, integer values of zero would correctly pass. After this change a zero value results in an empty field error.

Posted by Matthew Weier O'Phinney (matthew) on 2009-09-17T11:59:09.000+0000

Behavior now fixed in trunk and 1.9 release branch; integer 0 is now considered non-empty by the NotEmpty validator.

Posted by Simon Corless (sico) on 2009-10-25T10:31:52.000+0000

This fix with the NotEmpty validator has caused me nothing but trouble as it has broken a number of my forms. I used the fact that 0 in PHP is considered empty to validate lists where element 0 is a title thus not required.

I feel that the NotEmpty validator should behave in exactly the same way as the php function empty() with regards to integer 0. For the time being I have extended the notEmpty validator to disallow integer 0.

Should we fix this or implement another validator to cover such situations?

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.