Issues

ZF-7074: Remove python-isms from Zend_Gdata_YouTubeOnlineTest

Issue Type: Unit Tests: Task Created: 2009-06-21T15:37:04.000+0000 Last Updated: 2011-02-18T07:29:43.000+0000 Status: Resolved Fix version(s): - 1.11.4 (03/Mar/11)

Reporter: Trevor Johns (tjohns) Assignee: Rob Keplin (rkeplin) Tags: - Zend_Gdata

Related issues: Attachments: - zf-7074.diff

Description

Several method invocations in Zend_Gdata_YouTubeOnlineTest attempt to use named variables, even though this isn't supported by PHP. For example:

<pre class="literal">
        $httpClient = Zend_Gdata_ClientLogin::getHttpClient(
                                          $username = $this->user,
                                          $password = $this->pass,
                                          $service = $service,
                                          $client = null,
                                          $source = 'Google-UnitTests-1.0',
                                          $loginToken = null,
                                          $loginCaptcha = null,
                                          $authenticationURL);

should be:

<pre class="literal">
        $httpClient = Zend_Gdata_ClientLogin::getHttpClient(
                                          $this->user,
                                          $this->pass,
                                          $service,
                                          null,
                                          'Google-UnitTests-1.0',
                                          null,
                                          null,
                                          $authenticationURL);

It may be useful to add comments or use variables where the parameter being referred to isn't clear, but using the = operator is wasteful and should be removed.

Comments

Posted by Alexander Veremyev (alexander) on 2011-02-17T09:39:04.000+0000

Fixed. Fix is provided by Rob (shlumph)

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts