ZF-7297: Refactor Zend_Form_Element

Issue Type: Improvement Created: 2009-07-17T01:23:57.000+0000 Last Updated: 2012-11-09T10:03:48.000+0000 Status: Resolved Fix version(s): - 1.12.1 (18/Dec/12)

Reporter: Mathieu Suen (mathk) Assignee: Frank Brückner (frosch) Tags: - Zend_Form

  • FixForZF1.12
  • zf-crteam-needsexpert
  • zf-crteam-review

Related issues: Attachments: - Element.php.patch


I propose a small refactoring for speed and maintenability improvement. See attached file. Thanks to let me know if is it the right way to propose improvement.


Posted by Matthew Weier O'Phinney (matthew) on 2009-07-17T04:29:58.000+0000

I'm failing to see how this affects either performance or maintainability. Can you provide some benchmarks (and what was benchmarked) showing how it affects performance, as well as a rationale for why the change helps in maintainability?

Posted by Mathieu Suen (mathk) on 2009-07-20T01:23:43.000+0000

Insthead of appending the string in the loop it dose it outside + removing 2 temporary variables.

Posted by Frank Brückner (frosch) on 2012-07-30T15:15:43.000+0000

Test result with trunk version (2012-07-30): Tests passed

Posted by Frank Brückner (frosch) on 2012-07-30T15:21:18.000+0000

New patch file. (rebase)

Posted by Rob Allen (rob) on 2012-11-06T19:44:51.000+0000

Applied patch on trunk (25074) and release-1.12 (25075)

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.