Issues

ZF-7319: Dojo digit element doesn't assign an ID to dd html.

Issue Type: Improvement Created: 2009-07-20T05:42:21.000+0000 Last Updated: 2012-11-20T20:53:06.000+0000 Status: Closed Fix version(s): Reporter: Gordon Ansell (sentienthat) Assignee: None Tags: - Zend_Dojo

Related issues: Attachments:

Description

Compare loadDefaultDecorators() in Form/Element.php:

<pre class="highlight"> 
    public function loadDefaultDecorators()
    {
        if ($this->loadDefaultDecoratorsIsDisabled()) {
            return;
        }

        $decorators = $this->getDecorators();
        if (empty($decorators)) {
            $this->addDecorator('ViewHelper')
                ->addDecorator('Errors')
                ->addDecorator('Description', array('tag' => 'p', 'class' => 'description'))
                ->addDecorator('HtmlTag', array('tag' => 'dd',
                                               'id'  => $this->getName() . '-element'))
                ->addDecorator('Label', array('tag' => 'dt'));
        }
    }

With Dojo/Form/Element/Dijit.php

<pre class="highlight">
    public function loadDefaultDecorators()
    {
        if ($this->loadDefaultDecoratorsIsDisabled()) {
            return;
        }

        $decorators = $this->getDecorators();
        if (empty($decorators)) {
            $this->addDecorator('DijitElement')
                 ->addDecorator('Errors')
                 ->addDecorator('Description', array('tag' => 'p', 'class' => 'description'))
                 ->addDecorator('HtmlTag', array('tag' => 'dd'))
                 ->addDecorator('Label', array('tag' => 'dt'));
        }
    }

The former adds 'id' => $this->getName() . '-element' to the dd HtmlTag, the latter doesn't.

Comments

Posted by Rob Allen (rob) on 2012-11-20T20:53:06.000+0000

Bulk change of all issues last updated before 1st January 2010 as "Won't Fix".

Feel free to re-open and provide a patch if you want to fix this issue.

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts