ZF-7423: Inexisting property _config in class Zend_Queue_Adapter_Db

Issue Type: Bug Created: 2009-07-30T13:11:06.000+0000 Last Updated: 2009-09-23T10:32:32.000+0000 Status: Resolved Fix version(s): - 1.9.4 (13/Oct/09)

Reporter: Jeroen van Dijk (neorey) Assignee: Satoru Yoshida (satoruyoshida) Tags: - Zend_Queue

Related issues: Attachments: - Db.php.patch


In the receive function of the Db adapter, a call to $this->_config is done in the receive method whereas it should be $this->_options Patch:

<pre class="highlight">
Index: library/Zend/Queue/Adapter/Db.php
--- library/Zend/Queue/Adapter/Db.php   (revision 17310)
+++ library/Zend/Queue/Adapter/Db.php   (working copy)
@@ -349,7 +349,7 @@
             $query = $db->select();
-            if ($this->_config['options'][Zend_Db_Select::FOR_UPDATE]) {
+            if ($this->_options['options'][Zend_Db_Select::FOR_UPDATE]) {
                 // turn on forUpdate


Posted by Jeroen van Dijk (neorey) on 2009-07-30T13:26:12.000+0000

Patch file added

Posted by Satoru Yoshida (satoruyoshida) on 2009-07-30T19:17:52.000+0000

Solved in SVN r17318 in trunk. It will be release at 1.9.1

Posted by Dolf Schimmel (Freeaqingme) (freak) on 2009-07-31T19:32:36.000+0000

Maybe a good idea to add/update the appropriate unittests?

Posted by Satoru Yoshida (satoruyoshida) on 2009-08-01T18:37:48.000+0000

Do you have nice idea to check difference of results whether lacks of [Zend_Db_Select::FOR_UPDATE] ?

Posted by Dolf Schimmel (Freeaqingme) (freak) on 2009-08-01T18:45:02.000+0000

Sorry, I suck at unittests. For the moment I'm reopening this issue until there's someone who knows how to add tests for this (or someone who says it's impossible to add tests for this).

Posted by Antonio Ruiz Zwollo (jaruz) on 2009-09-01T09:26:47.000+0000

The 2nd comment (Satoru Yoshida - 30/Jul/09 07:17 PM) states the fix would be released with 1.9.1. I can confirm the bug is still present in 1.9.2.

Posted by Satoru Yoshida (satoruyoshida) on 2009-09-01T15:12:15.000+0000

Thanks confirm, Antonio. Sorry. I forgot to merge into 1.9 branch. :-( So, I change the Fix Version to Next Minor.

Posted by Jeroen van Dijk (neorey) on 2009-09-22T03:05:01.000+0000

I just saw that 1.9.3 is tagged. Regarding the previous comment, will this fix be included in 2.0? Because it's not included in the 1.9.3 release.

Posted by Matthew Weier O'Phinney (matthew) on 2009-09-22T05:38:40.000+0000

Jeroen - Once merged to the 1.9 release branch, we can release it. Satoru -- if you could please merge it ASAP, we can include it in 1.9.4 in early October.

(BTW, next minor release will be 1.10, and is some months away; we have twice-monthly maintenance releases between minor releases.)

Posted by Jeroen van Dijk (neorey) on 2009-09-22T05:46:33.000+0000

Thanks for the heads up! And sorry for the misconception about minor-releases... of course 1.10 and not 2.0!

Posted by Satoru Yoshida (satoruyoshida) on 2009-09-23T03:54:24.000+0000

Hi, Jeroen and Matthew, I just merged into 1.9 branch at SVN r18384 from trunk 17318.

So we could see it solved in next mini :-)

Posted by Benjamin Eberlei (beberlei) on 2009-09-23T10:28:42.000+0000

Commit r18384 has another change that is not in accordance with this patch, Saturo can you comment on the diff?…

Posted by Benjamin Eberlei (beberlei) on 2009-09-23T10:32:08.000+0000

just saw this change is no problem. sorry for the buzz

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.