ZF-8383: Zend_Translate_Adapter_Xliff: use own attribut trans-unit id as array keys for $this->_translate instead of source strings

Issue Type: Improvement Created: 2009-11-24T07:57:34.000+0000 Last Updated: 2009-12-06T07:01:54.000+0000 Status: Resolved Fix version(s): - 1.10.0 (27/Jan/10)

Reporter: Sven (sunnysven) Assignee: Thomas Weidner (thomas) Tags: - Zend_Translate

Related issues: Attachments:




Posted by Thomas Weidner (thomas) on 2009-11-24T08:10:00.000+0000

Transunit ID is an optional element so we can not use it because it's optional.

Additionally you forgot the negs of such an change. * when something is not translated your user would get cryptic keys * when something changes in your source the xliff tool would not be aware of the change as there would be no connex between source and target * within your source there would be no way for the author (which could be another person than the coder) to know what is meant without looking into the translation file

Posted by Sven (sunnysven) on 2009-11-24T08:32:31.000+0000

"Transunit ID is an optional element so we can not use it because it's optional."

Transunit ID is required in XLIFF 1.1 and 1.2 Specification: "The required id attribute is used to identify the within the file".……

Posted by Thomas Weidner (thomas) on 2009-11-24T11:04:28.000+0000

This does not change what I said before.

When you are in need of short translations, also within your code like you wrote before you should use the mentioned "id" as source.

Changing the behaviour of this single adapter to something which does not conform how translation is done in the rest of this framework is actually no option.

Posted by Sven (sunnysven) on 2009-11-25T02:34:15.000+0000

It's a pity that it is not possible to implement an optional paramater (for reasons of backward compatibility) to instruct the adapter to select the Transunit ID and not the source string as array key.

Posted by Thomas Weidner (thomas) on 2009-11-25T10:48:41.000+0000

No for this feature.

It would change behaviour in relation to all other adapters. Additionally it would add the above described problems.

When you are in need of a "special" version you can still simply extend the related adapter and create your own specialized version.

Posted by Thomas Weidner (thomas) on 2009-11-25T12:20:15.000+0000


Compared with TMX format which are both from LISA. Based on TMX I agree to add such an option for XLIFF.

Posted by Thomas Weidner (thomas) on 2009-12-06T07:01:54.000+0000

Based on the xliff standard the usage was fixed. Integrated with r19457.

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.