ZF-8560: remove unnecessary parameter manipulation in ZendX_JQuery_View_Helper_JQuery_Container::addJavascript()

Issue Type: Improvement Created: 2009-12-16T15:15:17.000+0000 Last Updated: 2010-01-29T01:47:32.000+0000 Status: Resolved Fix version(s): Reporter: Martin Minka (k2s) Assignee: Benjamin Eberlei (beberlei) Tags: - ZendX_JQuery

Related issues: - ZF-8011



Remove all manipulation of the passed JavaScript in ZendX_JQuery_View_Helper_JQuery_Container::addJavascript($js).

Actualy this function will: * trim $js * add ; if not found as last character

Reasons: * there is no benefit to do it * this processing is taking unnecessary CPU on each request * it is not perfect, for example if the last line is JavaScript comment the ; will still be added * it is works different from Zend_View_Helper_HeadScript::addJavascript() function * passed text has to be complete and valid JavaScript which means that more addJavascript functions can't be combined


No comments to display

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.