Issues

ZF-8740: Zend_Search_Lucene_Document_Html::getLinks() should parse AREA tags

Issue Type: Improvement Created: 2010-01-07T11:05:35.000+0000 Last Updated: 2010-04-19T00:27:43.000+0000 Status: Resolved Fix version(s): - 1.10.4 (28/Apr/10)

Reporter: John Nunez (jnuneznj) Assignee: Alexander Veremyev (alexander) Tags: - Zend_Search_Lucene

Related issues: Attachments: - Html.patch

Description

Zend_Search_Lucene_Document_Html will not list links from image maps. To resolve we just need to add code to pull in all urls from the AREA tag's href. I have a fix ready. Where should I post it?

Comments

Posted by John Nunez (jnuneznj) on 2010-01-07T11:09:03.000+0000

Here is the file which contains the fix.

Posted by Christopher Thomas (cwt137) on 2010-01-08T06:44:12.000+0000

It is better to submit a patch than the whole file. It is hard to see what has changed if you provide the whole file. If you don't know how to make a patch, it is easy. Just run this command at the root of your svn repo: "svn diff > file_name.patch" (without quotes).

Posted by Christopher Thomas (cwt137) on 2010-01-21T06:13:31.000+0000

Hello, I've added some unit tests to your patch. Please see attached file.

Posted by Alexander Veremyev (alexander) on 2010-04-18T12:02:39.000+0000

Fixed.

Nice patch, Christopher!

Posted by Alexander Veremyev (alexander) on 2010-04-18T12:08:25.000+0000

Wrong issue was resolved :) So, I've reopened it

Posted by Alexander Veremyev (alexander) on 2010-04-19T00:27:39.000+0000

Fixed in the trunk and in the release branch.

Must say again, good patch, John and Christopher! :)

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts