ZF-8835: Zend_Validate_Isbn uses incomplete and deprecated regular expression

Issue Type: Bug Created: 2010-01-16T03:37:33.000+0000 Last Updated: 2010-01-16T05:28:57.000+0000 Status: Resolved Fix version(s): - 1.10.0 (27/Jan/10)

Reporter: Menno Luiten (mluiten) Assignee: Thomas Weidner (thomas) Tags: - Zend_Validate

Related issues: Attachments: - ZF-8835.patch


The component uses ereg in _detectFormat

Ereg is deprecated as of PHP 5.3:

Also, the regular expression is not doing what it's supposed to do when using anything other than a blank separator. I think the underlined code below is supposed to check the total length of the string is equal to 17, but this does not work. See patch for a possible usage of preg_match instead of ereg and checking the string length separately, see attached patch.

<pre class="highlight">


Posted by Menno Luiten (mluiten) on 2010-01-16T03:39:05.000+0000

Attached patch

Posted by Thomas Weidner (thomas) on 2010-01-16T05:28:57.000+0000

Fixed with r20335

Thanks for your patch... solved it slightly differently

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.