ZF-9532: Conditional comments in headStyle()

Issue Type: Patch Created: 2010-03-24T10:50:16.000+0000 Last Updated: 2011-01-27T10:17:10.000+0000 Status: Resolved Fix version(s): - 1.11.3 (01/Feb/11)

Reporter: Alan Willms (dyulax) Assignee: Benoît Durand (intiilapa) Tags: - Zend_View

Related issues: Attachments: - HeadStyleTest.php


The followting code:

$this->headStyle()->appendStyle(" body { behavior:url('" . SERVER_STATIC_URL . PATH_URL_JAVASCRIPT . "iefix/'); } ", array('conditional' => 'IE 6'));

Will generate this HTML:


Note that the , before "", so that remains an unfinished tag and commentary end, invalidating the HTML.


Posted by __jul__ (__jul__) on 2010-04-24T16:32:13.000+0000

I've written a patch which resolves this issue.

It's my first patch, so please let me know if you require any additional information.

Cheers, Jeremy

Posted by Matthew Weier O'Phinney (matthew) on 2010-04-27T05:30:47.000+0000

Could you provide a unit test in your patch, please?

Posted by __jul__ (__jul__) on 2010-04-27T15:52:06.000+0000

Test attached. :)

Posted by Symphony IT (symphony) on 2011-01-26T08:24:32.000+0000

This is still an unresolved issue. It's still adding the nested comments in to the html and thus causing HTML validation issues.

Could you please sort this asap, it should be a relatively easy fix, especially since jul has provided you with the code.

Posted by Benoît Durand (intiilapa) on 2011-01-27T10:17:06.000+0000

Fix r23680

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.