Issues

ZF-9771: Zend_Dojo_Form_Element_ComboBox autocomplete feature fails when using declarative

Issue Type: Patch Created: 2010-04-29T10:41:14.000+0000 Last Updated: 2011-08-01T13:54:49.000+0000 Status: Resolved Fix version(s): - 1.11.6 (05/May/11)

Reporter: boris (jer) Assignee: Martijn Swaagman (swaagie) Tags: - Zend_Dojo

Related issues: - ZF-7078

Attachments: - Zend_Dojo_View_Helper_ComboBox.patch

Description

This part of code in Zend_Dojo_Form_Element_ComboBox line 152

<pre class="highlight">
    public function setAutocomplete($flag)
    {
        $this->setDijitParam('autocomplete', (bool) $flag);
        return $this;
    }

in conjunction with

<pre class="highlight">
Zend_Dojo_View_Helper_Dojo::setUseDeclarative();

when trying to set autocomplete feature to 'false' provides a dijit markup with autocompelete="" property which actualy means no value and autocomplete stays on (as it is by default in dojo). Same goes to Dojo_Form_Element_FilteringSelect as it derives from combobox.

Suggestion: set property as is, without type casting.

Comments

Posted by Martijn Swaagman (swaagie) on 2011-04-25T14:04:59.000+0000

Manual type casting of the true/false option was needed

Posted by Matthew Weier O'Phinney (matthew) on 2011-05-02T19:33:28.000+0000

Patch reviewed and applied to trunk and 1.11 release branch.

Posted by Robert Basic (robertbasic) on 2011-08-01T13:54:49.000+0000

Pull request for porting the patch in ZF2 is sent: https://github.com/zendframework/zf2/pull/308

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts