Issues

ZF-9797: Zend_Markup_Parser_Textile is unusable

Issue Type: Bug Created: 2010-05-03T22:28:08.000+0000 Last Updated: 2012-12-18T20:08:27.000+0000 Status: Resolved Fix version(s): - 1.12.1 (18/Dec/12)

Reporter: Artem Nezvigin (artnez) Assignee: Pieter Kokx (kokx) Tags: - Zend_Markup

  • FixForZF1.12
  • zf-crteam-review

Related issues: Attachments:

Description

Zend_Markup_Parser_Textile is in an unusable state I'm afraid. Using it in a production environment with real users writing real comments/articles wreaks havoc :(

Sample text; "Hi!"

Expected output: "

Hi!

"

Resulting output: "

Hi

"

The exclamation mark is stripped. This problem gets worse if you have something like this.

Sample text: "Hi! Check out "this link":http://google.com. Yay!"

Expected output: "Hi! Checkout this link. Yay!"

Resulting output: "

HiCheck out "this link":<a rel=http://google.com. Yay" alt="google" />

"

Also, Zend_Markup_Renderer_RendererAbstract has a call to $this->removeDefaultTags(); in the constructor. No such method is defined in Zend_Markup_Renderer_RendererAbstract or in Zend_Markup_Renderer_Html.

Was Zend_Markup supposed to be production ready? If not, my apologies for misunderstanding the situation!

Comments

Posted by Jachim Coudenys (coudenysj) on 2010-05-18T05:49:05.000+0000

It looks like all the tags in the $_simpleTags property suffer from this.

The check for tags only searches for 1 occurence (not enclosed tags).

<pre class="highlight">
$textile = Zend_Markup::factory('Textile');

echo $textile->render('Hi!');
// 

Hi

echo $textile->render('!Hi');
// 

<img alt="" src="http://Hi"></img>

echo $textile->render('Hi*');
// 

Hi

echo $textile->render('*Hi');
// 

<strong>Hi</strong>

echo $textile->render('Hi! Check out "this link":<a href="http://google.com">http://google.com</a>. Yay!');
// 

Hi<img alt="Check out &quot;this link&quot;:<a rel=" src=""></img>http://google.com. Yay" alt="google" />

Posted by Ross Masters (rmasters) on 2010-08-21T10:58:42.000+0000

Could I ask if there's a status update on this since May? I'd really like to use Textile in my app (preferably Markdown but I just need some sort of formatting).

If it helps here is a www.textism.com/tools/textile/?sample=2" rel="nofollow">great sample you can use for testing.

Posted by Alex Pogodin (alex_pogodin) on 2010-08-23T08:47:22.000+0000

I am also interested in Textile. Now I am forced to use native implementation from http://textile.thresholdstate.com/.

Are there any plans on this issue?

Posted by Barry Schut (barry,schut) on 2011-01-19T02:27:11.000+0000

27 oct the last update, changed from major to critical... if critical bugs take this long to fix, how long does it take to get major issues to be fixed?!

Please people, FIX THIS ASAP, this way the textile parser is realy not a viable option to use...

Posted by Barry Schut (barry,schut) on 2011-01-19T02:35:23.000+0000

Besides the obvious bug this issue describes... there is more:

http://textile.thresholdstate.com/

This page allows you to see what is supposed to be possible using textile, but something basic as ==== and notextile. are unknown to the parser ...

This renders it just about unusable...

Posted by Erik van Paassen (evpaassen) on 2011-12-04T16:34:55.000+0000

How is it possible that Zend_Markup_Parser_Textile, in this state, has made it to a stable ZF-release?

Posted by Adam Lundrigan (adamlundrigan) on 2012-02-24T03:12:24.000+0000

My recommendation is that unless someone steps up to fix this component for v1.12 it should be removed

Posted by Rob Allen (rob) on 2012-12-11T20:36:57.000+0000

On the grounds that no-one has volunteered to fix this. I have removed Zend_Markup_Parser_Textile from trunk (25156) and release-1.12 (25157).

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts