Issues

ZF2-238: Override global configuration module

Issue Type: Improvement Created: 2012-03-25T09:12:39.000+0000 Last Updated: 2012-04-04T15:06:26.000+0000 Status: Resolved Fix version(s): Reporter: BLANCHON Vincent (blanchon_vincent) Assignee: BLANCHON Vincent (blanchon_vincent) Tags: - Zend\ModuleManager

Related issues: Attachments:

Description

In Zend\Module\ConfigListener, the only method to override global modules configuration is :

public function addConfigGlobPath($globPath)

But the override is based on the glob() php function :

-> $config = ConfigFactory::fromFiles(glob($globPath, GLOB_BRACE))

The performance are slow with that. Why not a possibility to configure override with a static name, like addConfigGlobalFile('config/static/global.config.php') ?

Comments

Posted by Evan Coury (evan.pro) on 2012-03-26T19:02:03.000+0000

I have no objections to this if you want to submit a pull request.

Posted by BLANCHON Vincent (blanchon_vincent) on 2012-03-26T19:31:16.000+0000

How i can submit a patch to this ?

Posted by Frank Br├╝ckner (frosch) on 2012-03-27T15:49:50.000+0000

@BLANCHON Vincent

Create a github account

Fork the ZF2 repo

Add your changes

Send a pull request

Posted by BLANCHON Vincent (blanchon_vincent) on 2012-03-27T17:07:04.000+0000

Thank you :)

Posted by BLANCHON Vincent (blanchon_vincent) on 2012-03-29T11:10:06.000+0000

Ok, i have created a pull request (#978) https://github.com/zendframework/zf2/pull/978. Please do not hesitate to send me feedback. Thanks.

Have you found an issue?

See the Overview section for more details.

Copyright

© 2006-2016 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.

Contacts