ZF2-459: Wrong phpdoc comments and non-existing classes used

Issue Type: Bug Created: 2012-08-10T00:11:15.000+0000 Last Updated: 2012-10-08T20:16:34.000+0000 Status: Closed Fix version(s): Reporter: Michael Kliewe (mkliewe) Assignee: Ralph Schindler (ralph) Tags: - Zend\Db

  • Zend\Paginator
  • Zend\View

Related issues: - ZF2-467



I'm using RC3.

There are a lot classes used that do not exist. If you search for the following strings you will find them. I don't know how to fix them, because I don't know what the correct replacement/new class is in zf2.

\Zend\Db\Table \Zend\Db\Metadata\Table \Zend\Db\Metadata\ColumnCollection \Zend\Db\Metadata\ConstraintCollection

"ConstraintKeyObject" is wrong, and I cannot find a method "getColumnName()" anywhere /** @var $key \Zend\Db\Metadata\Object\ConstraintKeyObject */ $primaryKey[] = $key->getColumnName();

Should that be \PDO::FETCH_ASSOC? Db\Db::FETCH_ASSOC

Search for "\Zend\Loader\PluginLoader\Exception"

Search in whole project for "Object\ConstraintKeyObject"

PHPStorm tells me this is wrong (or bad code)? But maybe this is a false positive of PHPStorm. $this->handles[$index] = & $handles;

It would be cool if someone could have a look at all those classes and repair it.


Posted by Maks 3w (maks3w) on 2012-08-15T06:33:20.000+0000

[~mkliewe] Thank you for the report. Please the next time add the class which you found the issue.

The first block is a obsolete class will be removed by this PR

The second and fifth part will be fixed by [~ralph]

About the third part probably should be PDO, however Paginator still having old code not related with the new Zend\Db 2.0 API

About the fourth is obviously that the function only will throw a RuntimeException and neither Zend\Loader... or InvalidArgumentException so you can replace the @throws safely with RuntimeException and send us a PR with the patch

finally about the sixth I don't know.

Posted by Maks 3w (maks3w) on 2012-08-20T20:30:15.000+0000

Left fix some occurrences of ConstraintKeyObject

Posted by Ralph Schindler (ralph) on 2012-08-21T17:51:52.000+0000

<pre class="highlight">
$this->handles[$index] = & $handles;

Is valid, and I've seen that issue in PHPStorm. Where is that line exactly?

Posted by Michael Kliewe (mkliewe) on 2012-08-21T18:16:01.000+0000

If I search for "= & " in the whole project I find 26 occurrences. But only 5 of them are underlined in red (in PHPStorm). The files are: Zend/Cache/Storage/Plugin/ClearExpiredByFactor.php Zend/Cache/Storage/Plugin/ExceptionHandler.php Zend/Cache/Storage/Plugin/IgnoreUserAbort.php Zend/Cache/Storage/Plugin/OptimizeByFactor.php Zend/Cache/Storage/Plugin/Serializer.php

Posted by Ralph Schindler (ralph) on 2012-10-08T20:16:34.000+0000

This issue has been closed on Jira and moved to GitHub for issue tracking. To continue following the resolution of this issues, please visit:

Have you found an issue?

See the Overview section for more details.


© 2006-2018 by Zend, a Rogue Wave Company. Made with by awesome contributors.

This website is built using zend-expressive and it runs on PHP 7.